Google oauth #3884
Merged
Google oauth #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
xudaotutou
force-pushed
the
googleOauth
branch
from
5f6ef84
to
6f69653
Compare
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
c121914yu
reviewed
Sep 11, 2023
frontend/desktop/README.md
Outdated
| @@ -211,19 +211,22 @@ Open [http://localhost:3000](http://localhost:3000) with your browser to see the | |||
| ```bash | |||
There was a problem hiding this comment.
It does not belong to the bash command, so leave it blank
| // code = locationMap.get('access_token') ?? '' | ||
| // state = locationMap.get('state') ?? '' | ||
| } else { | ||
| throw new Error('provider error'); | ||
| } |
There was a problem hiding this comment.
const {data, code, state} = await (async() => {
return {
data,
....
}
})()
c121914yu
approved these changes
Sep 11, 2023
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
* f;eat(desktop): google oauth * style: add google icon * fix: icon type * fix: clean some error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 5f6ef84
Summary
✨♻️🔒
The pull request adds support for Google OAuth login in the frontend, along with custom icon components for the OAuth login buttons. It also refactors some existing code to use a common type for OAuth providers and to simplify the OAuth callback logic. The main files affected are
useAuthList.tsx,callback.tsx,session.ts,system.ts,user.ts, andgoogle/index.ts. The pull request also removes some unused and redundant code fromsignin/index.tsxandsignin.tsx.Walkthrough
Iconfrom@chakra-ui/react(link, link, link)useAuthListhook to use icon components and add Google OAuth button (link, link, link, link)SigninPageandCallbackcomponents (link, link, link, link, link, link)frontend/desktop/src/pages/api/auth/oauth/google/index.ts(link)getEnvAPI handler to include Google OAuth environment variables and check if Google OAuth is enabled (link, link, link, link)Callbackcomponent by redirecting to/signinpage if OAuth login fails (link)enableGoogleinfrontend/desktop/src/services/enable.tsto check Google OAuth environment variables (link)OauthProviderinfrontend/desktop/src/stores/session.tsandfrontend/desktop/src/types/user.tsto represent OAuth providers (link, link, link, link, link)google_client_idandneedGoogleproperties toLoginPropstype infrontend/desktop/src/types/system.ts(link, link)