Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): delete .kube dir for all nodes #3911

Merged
merged 1 commit into from Sep 13, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Sep 12, 2023

🤖 Generated by Copilot at 8972ff7

Summary

🧹🔐🐮

This pull request improves the node reset functionality for both kubernetes and k3s packages, by ensuring that the .kube directory is properly removed from the nodes. This prevents potential conflicts or security issues with leftover configuration files and credentials.

We are the masters of the nodes
We purge them of their secrets
We wield the sshClient as our sword
We execute the rm -rf

Walkthrough

  • Remove .kube directory from node's home directory after uninstalling k3s (link, link, link)
  • Update removeKubeConfig constant to take node's home directory as an argument (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Sep 12, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 932
✅ Successful 392
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 539
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@cuisongliu cuisongliu added this to the v4.4 milestone Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu merged commit 3f80a81 into labring:main Sep 13, 2023
80 checks passed
@cuisongliu cuisongliu deleted the reset_node_kube branch September 13, 2023 02:40
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6167325947

sealos-ci-robot pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Sep 13, 2023
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants