Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop): When a team member is kicked out, there is inconsistenc… #3930

Merged
merged 1 commit into from Sep 19, 2023

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Sep 14, 2023

…y between the front-end and back-end states.

🤖 Generated by Copilot at c4874a4

Summary

🆕🐛🚀

This pull request refactors the NsList component to use a more efficient data fetching hook, fixes indentation issues in the costcenter frontend provider, adds a new prop to handle null namespaces in the NsMenu component, prevents rendering an empty team management box in the TeamCenter component, and simplifies the user session authentication logic in the auth.ts service. These changes improve the performance, usability, and readability of the sealos frontend.

Oh we're the coders of the costcenter ship
And we work hard to make it run
We tweak the props and the queries and the hooks
And we fix the bugs one by one

Walkthrough

  • Remove unnecessary query for user token and obtain it from server response in authSession function (link)
  • Invalidate team list query when switching or deleting teams in NsList component (link, link)
  • Add nullNs prop to handle no namespace selected case in NsList component and pass it from NsMenu component (link, link)
  • Add condition to render team management box only when team user data is available in TeamCenter component (link)
  • Adjust indentation of various expressions to match code style and improve readability in BillingTable component (link, link, link)
  • Rename ns_uid prop to selected_ns_uid to avoid confusion in NsList component (link)
  • Remove unused import of useSessionStore hook in NsList component (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Sep 14, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 961
✅ Successful 399
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 561
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

…y between the front-end and back-end states.
@c121914yu c121914yu merged commit 094ce77 into labring:main Sep 19, 2023
22 of 23 checks passed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants