add database monitor #3934
Merged
add database monitor #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
lingdie
reviewed
Sep 15, 2023
service/database/api/req.go
Outdated
Comment on lines
16
to
17
| type PromMetric struct { | ||
| } |
There was a problem hiding this comment.
why use this empty struct?
lingdie
reviewed
Sep 15, 2023
service/database/server/server.go
Outdated
Comment on lines
141
to
147
| go ps.Authenticate(errChan1, pr) | ||
| go ps.DBReq(resChan, errChan2, pr) | ||
|
|
||
| err1 := <-errChan1 | ||
| err2 := <-errChan2 | ||
| res := <-resChan | ||
|
|
There was a problem hiding this comment.
Adjust the logic to prevent excessive db queries due to failed authentication
lingdie
approved these changes
Sep 18, 2023
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
* add: restserver for database monitor * add: victoriaMetrics for database monitor * Delete req.go.bak * fix: change database monitor server directory * Update vmstorage.yaml * fix: blocks without displaying an error * fix: database monitor * Update services.yml * fix: database monitor * fix: database monitor * fix: database monitor * fix: database monitor * fix: database monitor * fix: database monitor * Update go.work * Update vmagent.yaml * Update vmagent.yaml * Update vminsert.yaml * Update vmselect.yaml * Update vmstorage.yaml * fix: database monitor * fix: database monitor * fix: database monitor * fix: database monitor * fix: database monitor * fix: authentication and query * fix: authentication and query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 1846fe2
Summary
🗄️🚀🔐
This pull request adds a new service/database module to the sealos project, which provides a REST API for querying metrics from a VictoriaMetrics cluster. It includes the code, tests, configuration, documentation, Dockerfile and Kubernetes manifests for the service. It also updates the GitHub workflow and the go.work file to include the new module.
Walkthrough