Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: template offline environment #3936

Merged
merged 2 commits into from Sep 15, 2023
Merged

feat: template offline environment #3936

merged 2 commits into from Sep 15, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Sep 15, 2023

🤖 Generated by Copilot at 853e8d5

Summary

🐛🌐♻️

This pull request improves the cronjob UI by enhancing the translations and the data fetching logic. It also adds error handling to the updateRepo API for the fast deploy template.

updateRepo fails
catch and log the error now
autumn debugging

Walkthrough

  • Update the English and Chinese translations of the cronjob UI to use consistent and clear terms (link, link, link, link)
  • Import the useEffect hook in the edit/index.tsx component to fetch the cronjob data from the API (link)
  • Destructure the i18n object from the useTranslation hook in the edit/index.tsx component to change the language of the UI based on the user's preference (link)
  • Wrap the updateRepo API handler in a try-catch block to handle any errors when cloning or pulling the git repository for the fast deploy template in updateRepo.ts (link)

Signed-off-by: jingyang <3161362058@qq.com>
Signed-off-by: jingyang <3161362058@qq.com>
@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 930
✅ Successful 390
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 539
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@c121914yu c121914yu merged commit 6ee5911 into labring:main Sep 15, 2023
28 of 29 checks passed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
* fix cronjob text

Signed-off-by: jingyang <3161362058@qq.com>

* fix: template offline environment

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants