Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terminal):auto switch namespace #3959

Merged
merged 1 commit into from Sep 19, 2023

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Sep 18, 2023

πŸ€– Generated by Copilot at 829203c

Summary

πŸ”πŸŽ¨πŸ› οΈ

This pull request improves the frontend code quality, user experience, and security by applying formatting, simplifying expressions, using session data, and updating imports. It affects the costcenter, terminal, desktop, and license providers and the files billingTable.tsx, index.tsx, getSalt.ps1, session.ts, and tsconfig.json.

We're coding for the desktop frontend, me hearties
We're formatting and importing and fixing bugs
We're using PowerShell and TypeScript and Next.js
We're heaving away on the count of three

Walkthrough

  • Add a PowerShell script to get the JWT secret from the Kubernetes secret and convert it from base64 to string (link)
  • Import the useSessionStore hook and the Session type from the sealos-desktop-sdk package to access the user session data in the Terminal component and the session store (link, link)
  • Send a command to set the Kubernetes namespace to the current user's namespace in the Terminal component using a second postMessage call (link)
  • Simplify the ternary operator in the BillingTable component (link)
  • Format the code in various files to make it more readable and consistent with the rest of the codebase (link, link, link, link, link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Sep 18, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 961
βœ… Successful 399
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 561
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

? t('Charge')
: item.type === 2
? t('Recipient')
: t('Transfer')}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not format?

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch has no changes to coverable lines.

πŸ“’ Thoughts on this report? Let us know!.

@c121914yu c121914yu merged commit 6d047b7 into labring:main Sep 19, 2023
22 of 23 checks passed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants