fix: add timeout for command execution #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
cuisongliu
approved these changes
Sep 25, 2023
|
/cherry-pick release-v4.4 |
|
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Sep 25, 2023
cuisongliu
pushed a commit
that referenced
this pull request
Sep 25, 2023
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 6b46101
Summary
🕒🛠️🚀
Added command execution timeout feature to
pkg/sshpackage and improved the timeout and error handling of SSH commands. This feature allows the user to control the duration of command execution and avoid blocking or hanging issues.Walkthrough
CmdAsyncfunction inpkg/exec/exec.goto use context with timeout (link)timeoutinpkg/ssh/option.go(link)CmdAsyncWithContextfunction inpkg/ssh/sshcmd.go(link)