-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(costcenter):measure by app #3983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
π€ Generated by lychee actionSummary
Errors per inputErrors in README_zh.md
Errors in README.md
Full action output |
c121914yu
reviewed
Sep 26, 2023
}) { | ||
const { isOpen, onClose, onOpen } = useDisclosure(); | ||
const { t } = useTranslation(); | ||
console.log(optional); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
c121914yu
approved these changes
Sep 26, 2023
Codecov ReportAll modified lines are covered by tests β π’ Thoughts on this report? Let us know!. |
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
* feat(costcenter):measure by app * Update TypeMenu.tsx --------- Co-authored-by: Archer <545436317@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Generated by Copilot at c9e5f88
Summary
ππ οΈπ
This pull request adds new features, fixes, and improvements to the costcenter frontend. It adds new components for filtering, searching, and displaying the billing records, such as
AppMenu
,NamespaceMenu
,SearchBox
,SwitchPage
,TypeMenu
, andBillingDetails
. It also adds localization support for English and Chinese languages, and updates the UI layout and style of the billing and valuation pages. It fixes some typos, bugs, and unused code in the frontend and the API endpoints, such as theCurrencySymbol
component name, thequeryType
value, and thedns
module import. It also adds some new properties to theBillingItem
type, such asappType
andname
.Walkthrough