fix: using extra valid status codes when response status code greater than 400 #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
cuisongliu
approved these changes
Sep 25, 2023
|
/cherry-pick release-v4.4 |
|
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Sep 25, 2023
cuisongliu
pushed a commit
to cuisongliu/sealos
that referenced
this pull request
Sep 29, 2023
… than 400 (labring#3986) (labring#3988) Co-authored-by: fengxsong <fengxsong@outlook.com> (cherry picked from commit 7be765f)
cuisongliu
added a commit
that referenced
this pull request
Sep 29, 2023
* fix: dnsDomain does not take effect in kubelet (#3834) (#3835) Signed-off-by: yangxg <yangxggo@163.com> Co-authored-by: yangxg <yangxggo@163.com> (cherry picked from commit c60b2fd) * fix: ignore http server close error (#3854) (#3857) (cherry picked from commit 2d4d78b) * fix: skip same path (#3898) (#3899) Co-authored-by: 榴莲榴莲 <78798447@qq.com> (cherry picked from commit a256283) * fix: disable scp checksum by default (#3913) (#3919) Co-authored-by: fengxsong <fengxsong@outlook.com> (cherry picked from commit 96cb79d) * feat: support timeout setting for lvscare http prober (#3901) (#3905) Co-authored-by: fengxsong <fengxsong@outlook.com> (cherry picked from commit 6bd5c0a) * feature: kubefile CMD support ENV variable format (#3921) (#3942) Co-authored-by: Zihan Li <eden.zh.li@outlook.com> (cherry picked from commit 4b5f3fe) * delete cr build for buildah (#3953) (#3954) Co-authored-by: yy <56745951+lingdie@users.noreply.github.com> (cherry picked from commit 865803c) * delete: controller part and useless service. (#3950) * delete controllers and useless service. * delete buildah image cr part. * delete ci. * roll back (cherry picked from commit 076c7c7) Signed-off-by: cuisongliu <cuisongliu@qq.com> * fix: using extra valid status codes when response status code greater than 400 (#3986) (#3988) Co-authored-by: fengxsong <fengxsong@outlook.com> (cherry picked from commit 7be765f) * feature(main): add lvscare gomod (#3995) Signed-off-by: cuisongliu <cuisongliu@qq.com> (cherry picked from commit 050d70b) * fix(main): sync cert for cert cmd Signed-off-by: cuisongliu <cuisongliu@qq.com> #3708 #3887 --------- Co-authored-by: sealos-ci-robot <109538726+sealos-ci-robot@users.noreply.github.com> Co-authored-by: yy <56745951+lingdie@users.noreply.github.com>
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 0e3688d
Summary
🐛🚀📝
Fixed a bug and improved performance and clarity of the
health-statusoption for HTTP probes inlvscare. This option allows customizing the valid status codes for health checks inprober.go.Walkthrough
health-statusto accept extra valid status codes greater than 400 (link)Probefunction to check the status code range first, and then the valid status set (link)