Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costcenter): fix get price error #4007

Merged
merged 1 commit into from Sep 27, 2023

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Sep 27, 2023

🤖 Generated by Copilot at 463057d

Summary

🔒🚀♻️

This pull request enhances the frontend costcenter service by using backend functions to get the user's namespace for billing and price queries, and by disabling the billing table row for non-consumable items. This improves the user experience and the code quality.

Sing, O Muse, of the skillful coder who changed the frontend costcenter
And made it more robust and elegant with backend function and condition
He who disabled the billing row for the non-consumable items
Like Zeus who thunders and hurls his bolts at the insolent Titans

Walkthrough

  • Add a condition to disable billing table row for non-consumable items (link)
  • Use GetUserDefaultNameSpace function to get user's namespace in getAppList.tsx and price/index.ts (link, link, link, link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 973
✅ Successful 400
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@lingdie lingdie merged commit 0a45da3 into labring:main Sep 27, 2023
26 of 27 checks passed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants