Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main): delete clean_unused_func #4017

Merged
merged 1 commit into from Sep 29, 2023
Merged

fix(main): delete clean_unused_func #4017

merged 1 commit into from Sep 29, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Sep 29, 2023 •
edited by ghost

🤖 Generated by Copilot at ce50eb8

Summary

🗑️🔀🔐

Removed SendNewCertAndKeyToMasters method from KubeadmRuntime struct. Simplified certificate distribution logic by using sealos join command.

SendNewCertAndKey
Moved to sealos join command
No more duplication

Walkthrough

  • Remove SendNewCertAndKeyToMasters method from KubeadmRuntime struct (link)

@cuisongliu
fix(main): delete clean_unused_func
ce50eb8 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu added this to the v4.4 milestone Sep 29, 2023
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 973
✅ Successful 400
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu merged commit e3fbf75 into labring:main Sep 29, 2023
94 checks passed
@cuisongliu cuisongliu deleted the clean_unused_func branch September 29, 2023 01:15
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6346014559

sealos-ci-robot pushed a commit that referenced this pull request Sep 29, 2023
@cuisongliu
fix(main): delete clean_unused_func (#4017)
51a4c11 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Sep 29, 2023
@sealos-ci-robot @cuisongliu
fix(main): delete clean_unused_func (#4017) (#4018)
cb75187 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
This was referenced Sep 29, 2023
Merged
Closed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
@cuisongliu @bxy4543
fix(main): delete clean_unused_func (labring#4017)
86d8c22 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxy4543 bxy4543 bxy4543 approved these changes

Assignees
No one assigned
Labels
area/lifecycle-management area/runtime size/XS
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cuisongliu @sealos-ci-robot @bxy4543