Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create new container mount when force override #4068

Merged
merged 1 commit into from Oct 11, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Oct 11, 2023

🤖 Generated by Copilot at f0bbe89

Summary

🐛🗑️🎲

Fix bug in install processor of sealos that prevents overriding images. Delete existing container with same image name before creating new one.

sealos fixes bug
deletes old container first
then creates new one

Walkthrough

  • Delete existing container before overriding image (link)

Signed-off-by: fengxsong <fengxsong@outlook.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 942
✅ Successful 369
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu added this to the v4.4 milestone Oct 11, 2023
@cuisongliu cuisongliu merged commit c79c1b2 into labring:main Oct 11, 2023
94 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6480610330

sealos-ci-robot pushed a commit that referenced this pull request Oct 11, 2023
Signed-off-by: fengxsong <fengxsong@outlook.com>
cuisongliu pushed a commit that referenced this pull request Oct 11, 2023
Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>
cuisongliu pushed a commit to cuisongliu/sealos that referenced this pull request Oct 11, 2023
…abring#4072)

Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>

(cherry picked from commit 4242e7c)
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu pushed a commit to cuisongliu/sealos that referenced this pull request Oct 11, 2023
…abring#4072)

Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>

(cherry picked from commit 4242e7c)
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Oct 12, 2023
…4079)

(cherry picked from commit 4242e7c)

Signed-off-by: fengxsong <fengxsong@outlook.com>
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: sealos-ci-robot <109538726+sealos-ci-robot@users.noreply.github.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants