Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #4081 #4083

Merged
merged 1 commit into from Oct 12, 2023
Merged

fix: #4081 #4083

merged 1 commit into from Oct 12, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Oct 12, 2023 •
edited by ghost

๐Ÿค– Generated by Copilot at 3ca4a92

Summary

๐ŸŒ๐Ÿ–ผ๏ธ๐Ÿ—บ๏ธ

Added custom environment variables support for cluster images. This allows users to specify additional environment variables for the cluster components in the cluster.Spec.Env field.

img.Env and cluster.Spec.Env unite
To forge the custom variables of might
They merge their maps in a fiery blaze
To unleash the cluster images' rage

Walkthrough

  • Merge cluster environment variables with image environment variables (link)
  • Import maps package to use its utility functions for manipulating maps of strings (link)

@fengxsong
fix: labring#4081
3ca4a92 
Signed-off-by: fengxsong <fengxsong@outlook.com>
@sweep-ai
Copy link

sweep-ai bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sealos-ci-robot
Copy link
Member

๐Ÿค– Generated by lychee action

Summary

Status Count
๐Ÿ” Total 948
โœ… Successful 369
โณ Timeouts 0
๐Ÿ”€ Redirected 0
๐Ÿ‘ป Excluded 578
โ“ Unknown 0
๐Ÿšซ Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage ฮ”
pkg/apply/gen.go 38.46% <0.00%> (-0.76%) โฌ‡๏ธ

๐Ÿ“ข Thoughts on this report? Let us know!.

@cuisongliu cuisongliu added this to the v4.4 milestone Oct 12, 2023
@cuisongliu cuisongliu linked an issue Oct 12, 2023 that may be closed by this pull request
BUG: The env set by gen does not take effect at runtime #4081
Closed
@cuisongliu cuisongliu merged commit 6b01bf2 into labring:main Oct 12, 2023
92 of 94 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

๐Ÿค– says: cherry pick action finished successfully ๐ŸŽ‰!
See: https://github.com/labring/sealos/actions/runs/6493836101

sealos-ci-robot pushed a commit that referenced this pull request Oct 12, 2023
@fengxsong
fix: #4081 (#4083)
c4f7b52 
Signed-off-by: fengxsong <fengxsong@outlook.com>
@fengxsong fengxsong deleted the fix_4081 branch October 12, 2023 09:33
cuisongliu pushed a commit that referenced this pull request Oct 12, 2023
@sealos-ci-robot @fengxsong
fix: #4081 (#4083) (#4085)
62e8e00 
Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/apply sealos run/apply/scale/reset area/lifecycle-management size/XS
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

BUG: The env set by gen does not take effect at runtime
3 participants
@fengxsong @sealos-ci-robot @cuisongliu