Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sync registry contents via ssh #4106

Merged
merged 1 commit into from Oct 17, 2023
Merged

fix: sync registry contents via ssh #4106

merged 1 commit into from Oct 17, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Oct 17, 2023 •
edited by ghost

🤖 Generated by Copilot at 1ead170

Summary

🔄🚀🐛

Improved the registry sync feature by using concurrency, error handling, and performance optimizations. Removed unused and redundant code from pkg/filesystem/registry/sync.go.

Sing, O Muse, of the mighty refactor
That the skilled coder wrought with swift fingers
He made registry sync run faster
With goroutines and channels, those wonders

Walkthrough

  • Add constants for sync modes and refactor sync logic to use goroutines and channels (link,link,link)
  • Modify error handling of async command execution to ignore context canceled error (link)
  • Remove unused imports from registry package (link)

@fengxsong
fix: sync registry contents via ssh
1ead170 
Signed-off-by: fengxsong <fengxsong@outlook.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 952
✅ Successful 371
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu added this to the v4.4 milestone Oct 17, 2023
@cuisongliu cuisongliu merged commit 92af429 into labring:main Oct 17, 2023
94 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6547330468

sealos-ci-robot pushed a commit that referenced this pull request Oct 17, 2023
@fengxsong
fix: sync registry contents via ssh (#4106)
655e558 
Signed-off-by: fengxsong <fengxsong@outlook.com>
cuisongliu pushed a commit that referenced this pull request Oct 17, 2023
@sealos-ci-robot @fengxsong
fix: sync registry contents via ssh (#4106) (#4109)
c8f7a9c 
Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>
@fengxsong fengxsong deleted the fix_sync_registry branch October 18, 2023 01:56
This was referenced Oct 19, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/filesystem area/lifecycle-management size/L
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fengxsong @sealos-ci-robot @cuisongliu