Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync image #4119

Merged
merged 1 commit into from Oct 19, 2023
Merged

fix sync image #4119

merged 1 commit into from Oct 19, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 19, 2023

🤖 Generated by Copilot at 5baf68c

Summary

🗑️📦⚡

Simplify registry directory copying by removing unused argument. The change affects the ssh.CopyDir function call in pkg/filesystem/registry/sync.go.

CopyDir simpler
No need to filter files now
Registry is clear

Walkthrough

  • Simplify the ssh.CopyDir function call by removing the constants.IsRegistryDir argument (link)

@bxy4543
Copy link
Member Author

bxy4543 commented Oct 19, 2023

need test

@sweep-ai
Copy link

sweep-ai bot commented Oct 19, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment