Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return converted component configs #4121

Merged
merged 1 commit into from Oct 20, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Oct 20, 2023

πŸ€– Generated by Copilot at eb87ad1

Summary

πŸ”„πŸš€πŸ› οΈ

Refactor GetComponents method of KubeadmConfig to use external kubeadm API version. This improves compatibility and simplifies config handling in sealos.

KubeadmConfig changed
To convert before return
Simpler and safer

Walkthrough

  • Convert the internal kubeadm config to the external version before returning the components in GetComponents (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 20, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 952
βœ… Successful 369
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 2

Errors per input

Errors in deploy/registry/README.md

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 20, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@fengxsong fengxsong marked this pull request as draft October 20, 2023 02:57
Signed-off-by: fengxsong <fengxsong@outlook.com>
@fengxsong fengxsong marked this pull request as ready for review October 20, 2023 03:17
@cuisongliu cuisongliu added this to the v4.4 milestone Oct 20, 2023
@cuisongliu cuisongliu merged commit 15b094a into labring:main Oct 20, 2023
83 of 84 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

πŸ€– says: cherry pick action finished successfully πŸŽ‰!
See: https://github.com/labring/sealos/actions/runs/6583163022

sealos-ci-robot pushed a commit that referenced this pull request Oct 20, 2023
Signed-off-by: fengxsong <fengxsong@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants