Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Automated CherryPick Update for release-v4.4 #4142

Merged
merged 1 commit into from Oct 23, 2023
Merged

docs: Automated CherryPick Update for release-v4.4 #4142

merged 1 commit into from Oct 23, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Oct 23, 2023 •
edited by ghost

🤖 Generated by Copilot at 18a0a72

Summary

🔒🛠️🚨

Pin golangci-lint-action version in CI workflow. This fixes a compatibility issue with the latest version of the action and ensures consistent linting results.

golangci-lint-action
Pinned to avoid errors
A winter bug fix

Walkthrough

  • Pin the version of golangci-lint-action to v1.54.2 to avoid breaking changes (link)

Automated changes by create-pull-request GitHub action

@cuisongliu
refactor(main): fixed golang lint version (#4141)
18a0a72 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
@sweep-ai
Copy link

sweep-ai bot commented Oct 23, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@cuisongliu cuisongliu added this to the v4.3 milestone Oct 23, 2023
@cuisongliu cuisongliu merged commit 04c81fe into release-v4.4 Oct 23, 2023
27 checks passed
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.4-4141 branch October 23, 2023 03:49
@sealos-ci-robot
Copy link
Member Author

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member Author

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6608491022

sealos-ci-robot added a commit that referenced this pull request Oct 23, 2023
@sealos-ci-robot @cuisongliu
refactor(main): fixed golang lint version (#4141) (#4142)
003fcb1 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Oct 23, 2023
@sealos-ci-robot @cuisongliu
refactor(main): fixed golang lint version (#4141) (#4142) (#4143)
4057aac 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/workflow size/XS
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sealos-ci-robot @cuisongliu