π fix env merge for sealos run #4144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Generated by Copilot at 7fe5f62
Summary
π§ππΌοΈ
Refactored the
clusterfile
andguest
packages to use interfaces and variable merging for environment variables. This improves the code quality and flexibility for managing cluster nodes and images.Walkthrough
Process
function inpkg/clusterfile/pre_process.go
to useEnvGetter
interface instead of setting environment variables directly (link, link)NewGuestManager
function inpkg/guest/guest.go
to accept anEnvGetter
parameter instead of a map of environment variables (link)maps.MergeMap
function to merge image-specific and cluster-wide environment variables inpkg/guest/guest.go
before executing image commands (link, link)