New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(main): skip success exec #4162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cuisongliu <cuisongliu@qq.com>
🤖 Generated by lychee actionSummary
Full action output |
sealos-ci-robot
added
area/apply
sealos run/apply/scale/reset
area/lifecycle-management
area/api
labels
Oct 24, 2023
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
lingdie
approved these changes
Oct 26, 2023
/cherry-pick release-v4.4 |
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Oct 26, 2023
cuisongliu
added a commit
that referenced
this pull request
Oct 26, 2023
sealos-ci-robot
added a commit
that referenced
this pull request
Oct 26, 2023
cuisongliu
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 0264836
Summary
🐛🚫🚀
This pull request fixes a bug in the apply command that would report success even if there were no resources to apply or if the apply failed. It changes the
updateStatus
function inpkg/apply/applydrivers/apply_drivers_default.go
to return early if there are no new images, and removes the unusedNewSuccessCommandCondition
function frompkg/types/v1beta1/cluster.go
.Walkthrough
NewSuccessCommandCondition
that created a command condition with a success status and a message for the apply command (link)