Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imporve sealos cloud install script #4181

Merged
merged 2 commits into from Oct 27, 2023
Merged

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Oct 27, 2023

πŸ€– Generated by Copilot at b87844f

Summary

πŸ› οΈπŸ“πŸŒ

This pull request enhances the user experience and reliability of the scripts/cloud/install.sh script. It improves the language and layout of the messages, corrects some bugs and adds functions to handle failures and exit gracefully.

The cloud installation script
Was not very clear or equipped
To handle the errors
Or different languages
So this pull request gave it a lift

Walkthrough

  • Improve the clarity, consistency and user-friendliness of the English and Chinese prompts in the install.sh script (link, link, link, link, link, link, link)
  • Add a function to handle errors and exit the script gracefully, and set a trap to invoke the function when an error occurs (link)

Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 956
βœ… Successful 375
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 27, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@zzjin zzjin added this to the v5.0 milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@lingdie lingdie merged commit 3bc6c3c into labring:main Oct 27, 2023
43 checks passed
@lingdie lingdie deleted the install-script branch October 27, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants