Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costcenter): fix unit & invoice amount #4185

Merged
merged 1 commit into from Oct 28, 2023

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Oct 27, 2023

πŸ€– Generated by Copilot at 176b85c

Summary

πŸ’°πŸ› οΈπŸ“Š

Updated the frontend code for the costcenter provider to handle partial payments for billings and invoices. Changed the port for the dev script and the display of network resource prices.

Oh we're the coders of the sea, we make the invoices neat
We show the payment or the amount, whichever is complete
We round the prices and the units, we match the API
So heave away, me hearties, heave away on the count of three

Walkthrough

  • Modify InvoiceTable and Invoice components to handle partial payments (link, link)
  • Add optional payment property to ReqGenInvoice type to match backend API (link)
  • Round down price values to the nearest millionth in Valuation component (link)
  • Display unit and price conditionally based on resource type in Valuation component (link)
  • Specify port 3001 for next.js development server in dev script (link)
  • Add newline at the end of package.json file (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 27, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 956
βœ… Successful 375
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 27, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@c121914yu c121914yu closed this Oct 28, 2023
@c121914yu c121914yu reopened this Oct 28, 2023
@c121914yu c121914yu merged commit a3d7b2b into labring:main Oct 28, 2023
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants