Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Automated CherryPick Update for release-v4.4 #4191

Merged
merged 1 commit into from Oct 29, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Oct 29, 2023

🤖 Generated by Copilot at c63d38b

Summary

🐳🛠️🚀

This pull request enhances the image-cri-shim package to support multiple container runtimes and cgroup drivers from the containerd config file. It modifies the cri.go file to parse and use the runtime and cgroup settings.

Oh we are the brave containerd crew
We parse and use the runtime configs true
We don't assume runc is the only one
We heave away on the count of three, and respect the cgroup driver of the default one

Walkthrough

  • Define a new type Runtime to represent a container runtime configuration (link)
  • Use a map of Runtime instead of a struct for the runtimes section of the containerd config file (link)
  • Get the default runtime name and cgroup driver from the config file in processConfigFile (link)

Automated changes by create-pull-request GitHub action

@sweep-ai
Copy link

sweep-ai bot commented Oct 29, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu added this to the v4.3 milestone Oct 29, 2023
@cuisongliu cuisongliu merged commit 02cd978 into release-v4.4 Oct 29, 2023
32 checks passed
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.4-4189 branch October 29, 2023 10:14
@sealos-ci-robot
Copy link
Member Author

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member Author

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6682723482

sealos-ci-robot added a commit that referenced this pull request Oct 29, 2023
Co-authored-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Oct 29, 2023
Co-authored-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants