refactor(main): unmount override container (#4161)

[cuisongliu]

(cherry picked from commit 4fed20a)

🤖 Generated by Copilot at e489328

Summary

🔧🗃️🚀

This pull request enhances the handling of MountImage instances in the cluster.Status.Mounts slice by sorting, deduplicating, and appending them. It also simplifies the cluster.FindImage method and removes the cluster.SetMountImage method. These changes aim to avoid conflicts or errors when applying the cluster configuration.

Sing, O Muse, of the skillful coder who modified the cluster code
To find the image and its index, and return them both with ease
No longer needing to set the mount, he removed the method old
And made the slice of mounts more ordered, with the help of sorting god

Walkthrough

• Ensure that cluster.Status.Mounts slice is consistent and up-to-date with the latest MountImage instances (link, link)

• Import sort package in pkg/apply/processor/install.go (link)
• Create a map of ImageName to the index of the last occurrence in the slice and sort the indexes (link)
• Create a new slice of MountImage instances based on the sorted indexes and assign it to the cluster status (link)
• Check if a new MountImage instance already exists in the slice before appending it and remove the old one if found (link)

• Modify cluster.FindImage method to return both the index and the pointer to the MountImage instance in pkg/types/v1beta1/cluster_args.go (link)
  • Remove cluster.SetMountImage method as it is no longer needed (link)

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: Leftover TODOs in the code should be handled.
• Apply: All new business logic should have corresponding unit tests in the tests/ directory.
• Apply: Any clearly inefficient or repeated code should be optimized or refactored.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.