Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy prefix #4231

Merged
merged 1 commit into from Nov 2, 2023
Merged

add proxy prefix #4231

merged 1 commit into from Nov 2, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 2, 2023

πŸ€– Generated by Copilot at c0e672b

Summary

πŸŒπŸ› οΈβ¬‡οΈ

Added support for installing sealos from a proxy URL. Added a new --proxy-prefix option to ./scripts/cloud/install.sh and modified scripts/install.sh to use it.

To install sealos from a proxy
We added a new option, --proxy-prefix
It sets PROXY_PREFIX in the shell
And prepends it to DOWNLOADER_PREFIX as well
So the scripts/install.sh script can fetch the binary

Walkthrough

  • Add --proxy-prefix option to ./scripts/cloud/install.sh to allow user to specify a proxy URL for sealos binary installation (link, link, link, link)
  • Modify ./scripts/cloud/install.sh to use proxy_prefix variable and pass it to curl command as PROXY_PREFIX environment variable (link)
  • Modify scripts/install.sh to use PROXY_PREFIX environment variable and prepend it to DOWNLOADER_PREFIX variable (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Nov 2, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 970
βœ… Successful 377
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 592
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 2, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@yangchuansheng yangchuansheng added this to the v5.0 milestone Nov 2, 2023
@yangchuansheng yangchuansheng merged commit 183f7c7 into labring:main Nov 2, 2023
36 checks passed
@bxy4543 bxy4543 deleted the optimize/scripts branch November 3, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants