Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template deploy ingress temp. #4234

Merged
merged 1 commit into from Nov 9, 2023
Merged

Fix template deploy ingress temp. #4234

merged 1 commit into from Nov 9, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Nov 2, 2023

🤖 Generated by Copilot at 590832d

Summary

🌐🎨🔀

Update ingress host name for template applications. This change modifies the ingress.yaml.tmpl file to use a template. prefix for the ingress tls host name, to avoid certificate conflicts with other subdomains.

ingress tls changed
template. prefix added
avoiding conflicts

Walkthrough

  • Prefix ingress host name with template. to avoid conflicts with other subdomains (link)

Signed-off-by: zzjin <tczzjin@gmail.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 970
✅ Successful 377
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 592
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 2, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pkg/env/env.go 64.40% <100.00%> (+11.59%) ⬆️

📢 Thoughts on this report? Let us know!

@zzjin zzjin added this to the v5.0 milestone Nov 9, 2023
@zzjin zzjin merged commit 55b4807 into labring:main Nov 9, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants