Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix database service ci #4253

Merged
merged 2 commits into from Nov 4, 2023
Merged

fix database service ci #4253

merged 2 commits into from Nov 4, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Nov 4, 2023

πŸ€– Generated by Copilot at 6e59a84

Summary

πŸ—‘οΈπŸ”§πŸ§ͺ

This pull request enhances the cluster image testing workflow by cleaning up the local docker registry and updating the image references in the manifest file. This ensures that the workflow uses the correct and latest images for testing.

Sing, O Muse, of the valiant deeds of the coder
Who sought to improve the testing of the cluster images
And bravely modified the services.yml file
Adding steps to purge the docker registry and patch the manifest

Walkthrough

  • Patch the cluster images manifest file with the correct image name and tag (link). This ensures that the sealos cluster installer uses the images that were built and pushed by the workflow, and not the default ones. The image name and tag are dynamically generated by the workflow based on the branch name and commit hash. The script that performs the patching is hack/patch-manifest.sh.

Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 970
βœ… Successful 377
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 592
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

see 1 file with indirect coverage changes

πŸ“’ Thoughts on this report? Let us know!.

@lingdie lingdie merged commit 8ef3689 into labring:main Nov 4, 2023
50 of 51 checks passed
@lingdie lingdie deleted the SVC-CI branch December 7, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants