Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costcenter: invoice):fix amount #4294

Merged
merged 1 commit into from Nov 14, 2023

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Nov 14, 2023

🤖 Generated by Copilot at 720277b

Summary

🎨💰🌐

This pull request mainly adds payment amount information to the invoice data and calculations in the costcenter provider, and fixes some formatting and localization issues in the template and kubepanel plugins. It also removes some redundant or unnecessary fields from the invoice and billing types.

Some changes were made to the code
To fix bugs and make things more bold
The table titles got quotes
The payment amounts got notes
And the ReadMe text was localized, we're told

Walkthrough

  • Replace double quotes with single quotes in table titles for consistency (link, link, link)
  • Adjust indentation of JSX elements in container-detail.tsx for alignment (link)
  • Remove payment amount from invoice table in invoiceTable.tsx to avoid redundancy (link)
  • Add payment amount to invoice data in create_invoice/index.tsx to fix inconsistency (link, link)
  • Add payment field to billing item type in billing.ts to store payment amount information (link)
  • Remove payment field from request generate invoice type in invoice.ts to simplify invoice data (link)
  • Move closing tags of JSX elements to new lines in list.tsx and ReadMe.tsx for readability (link, link, link, link, link, link, link, link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 981
✅ Successful 312
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c39bd89) 65.45% compared to head (720277b) 65.45%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4294   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit ea37dc9 into labring:main Nov 14, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants