Fix desktop and use icons from packages instead of public #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4307 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
c121914yu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖[deprecated] Generated by Copilot at 784f15c
Summary
🚀🎨🚧
The pull request refactors various components in the
frontend/desktopproject to use the UI components and icons from the@chakra-ui/reactand@sealos/uipackages, instead of custom ones. This improves the code quality, consistency, and scalability of the UI, and also adds some new features, such as copying the user's ID and checking the sign up feature flag. The pull request also improves the performance and user experience of the application by using SWC to transpile thesealos-desktop-sdkpackage and by replacing dynamic imports with static imports. The pull request also removes some unused and redundant code and imports from the project.Walkthrough
enableSignUpfunction to check sign up feature status by environment variable infrontend/desktop/src/services/enable.ts(link)enableSignUpfunction to prevent sign up by password or oauth if feature is disabled infrontend/desktop/src/pages/api/auth/password/exist.ts(link,link) andfrontend/desktop/src/services/backend/oauth.ts(link,link)@sealos/uipackage in various components (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)@chakra-ui/reactlibrary in various components (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)Accountcomponent fromIndextoAccountinfrontend/desktop/src/components/account/index.tsx(link)UserMenucomponent with static import infrontend/desktop/src/components/desktop_content/index.tsx(link)frontend/desktop/src/services/backend/oauth.ts(link,link,link)frontend/desktop/src/services/backend/oauth.ts(link,link)transpilePackagesoption innextConfigobject infrontend/desktop/next.config.js(link)frontend/desktop/src/components/icons/GroupAdd.tsxandfrontend/desktop/src/components/icons/DeleteIcon.tsxfiles (link,link)