Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix bug for building documentation site #4310

Merged
merged 1 commit into from Nov 16, 2023

Conversation

yangchuansheng
Copy link
Collaborator

@yangchuansheng yangchuansheng commented Nov 16, 2023

🤖[deprecated] Generated by Copilot at 2bfd254

Summary

🚚🐛🔄

This pull request removes the redundant copying of Chinese translation files and directories in the deploy-docs-preview, deploy-docs-site, and Dockerfile workflows, and simplifies the sync-zh-files script in the website/package.json file. The overall purpose is to optimize the documentation site build process and avoid duplication of files.

sync-zh-files runs
Copying Chinese docs and blogs
No more duplication

Walkthrough

  • Remove the step of copying the Chinese translation files and directories from the docs and blog folders to the build path in the deploy-docs-preview and deploy-docs-site workflows (link, link). This simplifies the workflows and avoids duplication of files, since the sync-zh-files script in the website/package.json already does the same copying before running the docusaurus start or docusaurus build commands. These workflows are triggered by pull requests or pushes to the master branch and build a preview or production site for the documentation using docusaurus.

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1018
✅ Successful 340
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 677
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@zzjin zzjin added this to the v5.0 milestone Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (195165f) 65.45% compared to head (2bfd254) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4310   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzjin zzjin merged commit a3412cd into labring:main Nov 16, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants