Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix higress annotation. #4326

Merged
merged 1 commit into from Nov 21, 2023
Merged

Fix higress annotation. #4326

merged 1 commit into from Nov 21, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Nov 21, 2023

🤖[deprecated] Generated by Copilot at 7910549

Summary

📝🛡️🚀

Format a higress annotation value as a multiline string literal in ingress.go. This enhances the code quality and security of the adminer ingress controller.

defaultHigressAnnotations
Multiline string, safer, faster
Autumn of code

Walkthrough

  • Format the defaultHigressAnnotations map value for better readability and maintainability (link)

Signed-off-by: zzjin <tczzjin@gmail.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1032
✅ Successful 363
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@zzjin zzjin added this to the v5.0 milestone Nov 21, 2023
Copy link

sweep-ai bot commented Nov 21, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9095a2e) 65.45% compared to head (7910549) 65.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4326   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzjin zzjin merged commit bfe029c into labring:main Nov 21, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants