Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: admission for ingress delete #4327

Merged
merged 3 commits into from Nov 21, 2023
Merged

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Nov 21, 2023

🤖[deprecated] Generated by Copilot at 1053cb8

Summary

🐛🚀📝

Fix a bug in the admission controller that causes it to crash when the ingressAnnotationString flag is not set. Move the logger initialization and add a flag validation in controllers/admission/cmd/main.go.

SetLogger first
Avoid parsing empty flag
Winter bug is fixed

Walkthrough

  • Initialize the logger before using it in main.go (link)
  • Validate the ingressAnnotationString flag before parsing it in main.go (link)

Copy link

sweep-ai bot commented Nov 21, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1045
✅ Successful 365
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 679
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e82b92f) 65.45% compared to head (1053cb8) 65.45%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4327   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxy4543 bxy4543 merged commit 333f05d into labring:main Nov 21, 2023
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants