Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tmpl cloud port #4335

Merged
merged 1 commit into from Nov 23, 2023
Merged

fix tmpl cloud port #4335

merged 1 commit into from Nov 23, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 23, 2023

πŸ€–[deprecated] Generated by Copilot at 49d550c

Summary

πŸ›πŸ› οΈπŸ“

Fix YAML parsing bug in deploy.yaml.tmpl for terminal controller. Add quotes to PORT value to handle numeric values.

PORT in single quotes
YAML parsing error fixed
Winter bug no more

Walkthrough

  • Fix YAML parsing error for PORT value by wrapping it in single quotes (link)

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 1032
βœ… Successful 363
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (160b7a2) 65.45% compared to head (49d550c) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4335   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@bxy4543 bxy4543 added this to the v5.0 milestone Nov 23, 2023
@bxy4543 bxy4543 merged commit d705eb5 into labring:main Nov 23, 2023
42 checks passed
@bxy4543 bxy4543 deleted the fix/terminal_deploy branch November 23, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants