Feat/minio cost #4339
Merged
Feat/minio cost #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4339 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
bxy4543
force-pushed
the
feat/minio-cost
branch
from
f342dd9
to
993a9db
Compare
lingdie
reviewed
Nov 23, 2023
controllers/resources/main.go
Outdated
| @@ -19,6 +19,7 @@ package main | |||
| import ( | |||
| "context" | |||
| "flag" | |||
| objectstoragev1 "github/labring/sealos/controllers/objectstorage/api/v1" | |||
| @@ -93,6 +107,7 @@ func NewMonitorReconciler(mgr ctrl.Manager) (*MonitorReconciler, error) { | |||
| stopCh: make(chan struct{}), | |||
| periodicReconcile: 1 * time.Minute, | |||
| TrafficSvcConn: os.Getenv(TrafficSvcConn), | |||
| PromURL: os.Getenv(PrometheusURL), | |||
| (*resMap)[minioNamed.Name()] = initResources() | ||
| } | ||
| (*resMap)[minioNamed.Name()][corev1.ResourceStorage].Add(*resource.NewQuantity(size, resource.BinarySI)) | ||
| (*resMap)[minioNamed.Name()][resources.ResourceNetwork].Add(*resource.NewQuantity(bytes, resource.BinarySI)) |
…sage of object storage is not understand.
lingdie
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖[deprecated] Generated by Copilot at f342dd9
Summary
🗑️🚀📊
This pull request adds support for minio object storage service and node port service types to the resource controller, and removes the metering feature and its related code and dependencies. It also updates the go.sum file, the controller image tag, and the rbac rules for services and services/status resources.
Walkthrough
go.modandgo.sumfiles (link, link, link, link, link, link, link, link, link, link)monitor_controller.go(link, link, link, link, link, link, link)monitor_controller.go(link)kustomization.yaml(link)