Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:db service labels #4344

Merged
merged 1 commit into from Nov 27, 2023
Merged

fix:db service labels #4344

merged 1 commit into from Nov 27, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Nov 27, 2023

🤖[deprecated] Generated by Copilot at cd0db36

Summary

🏷️🧭🎛️

Changed metadata object of network service resource to use labels instead of annotations for some keys in frontend/providers/dbprovider/src/utils/json2Yaml.ts. This improves alignment with Kubernetes conventions and simplifies selector logic.

metadata shifts
from annotations to labels
spring cleaning the code

Walkthrough

  • Change metadata object of network service resource to use labels instead of annotations for identifying application and component (link)
  • Adjust network service tests to reflect the label changes in frontend/providers/dbprovider/src/utils/__tests__/yaml2Json.test.ts and frontend/providers/dbprovider/src/utils/__tests__/json2Yaml.test.ts (link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1036
✅ Successful 367
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@bxy4543 bxy4543 merged commit d2e6d78 into labring:main Nov 27, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants