Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return cors anno as nil if port is 443. #4356

Merged
merged 1 commit into from Nov 28, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Nov 28, 2023

πŸ€–[deprecated] Generated by Copilot at 19e6364

Summary

πŸ› οΈπŸŒπŸšͺ

Improved terminal controller logic and error handling. Modified getPort function to avoid using reserved ports for terminal connections in controllers/terminal/controllers/terminal_controller.go.

getPort returns
empty string for some ports
avoiding conflicts

Walkthrough

  • Return empty port for terminal if it is empty, 80 or 443 to avoid conflicts with HTTP and HTTPS protocols (link)

Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 994
βœ… Successful 321
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 672
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 28, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@lingdie lingdie merged commit 6fc583a into labring:main Nov 28, 2023
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants