Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rbac and fix minio user not exist error #4366

Merged
merged 2 commits into from Nov 30, 2023

Conversation

nowinkeyy
Copy link
Contributor

Null

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Nov 30, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1052
✅ Successful 384
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 667
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9466c12) 65.45% compared to head (ec83f9a) 65.45%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4366   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

value: '{{ .OSAdminSecret }}'
- name: OSInternalEndpoint
value: '{{ .OSInternalEndpoint }}'
- name: oSNamespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oSNamespace --> OSNamespace

@bxy4543 bxy4543 added this to the v5.0 milestone Nov 30, 2023
@bxy4543 bxy4543 merged commit ce57c32 into labring:main Nov 30, 2023
36 checks passed
@nowinkeyy nowinkeyy deleted the fix_minio branch November 30, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants