Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notification read status #4369

Merged
merged 1 commit into from Nov 30, 2023
Merged

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 30, 2023

🤖[deprecated] Generated by Copilot at 3437890

Summary

✨🏷️👀

Add feature to mark notifications as read or unread in debt_controller.go. Use constants for label keys and values and set default to unread.

New feature added
Mark notifications as read
Unread by default

Walkthrough

  • Add a new label to indicate the read status of notifications (readStatusLabel, falseStatus)
  • Define two constants for the label key and value in debt_controller.go (link)
  • Initialize and set the label for every notification in debt_controller.go (link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1073
✅ Successful 395
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 677
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@lingdie lingdie merged commit 4dedc10 into labring:main Nov 30, 2023
39 of 40 checks passed
@bxy4543 bxy4543 deleted the fix/isread_message branch December 8, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants