Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:db delete some databases #4379

Merged
merged 3 commits into from Dec 5, 2023
Merged

feat:db delete some databases #4379

merged 3 commits into from Dec 5, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Dec 5, 2023

🤖[deprecated] Generated by Copilot at d85a7b7

Summary

🗑️🐛✨

This pull request adds a new API handler to delete databases from the frontend, removes some unused database options from the UI, and fixes a bug in the request service that affected the delete database feature. The changes are part of the sealos database provider module.

delDBByName added
simpler UI, fixed DELETE
fall leaves databases

Walkthrough

  • Remove unsupported database options from the UI (link)
  • Add API handler to delete a database by name and its migrates and backups (delDBByName.ts, link)
  • Improve error handling and logging in the delete database API handler (link, link)
  • Fix HTTP method for the DELETE function in the request service (request.ts, link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 5, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1081
✅ Successful 395
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 685
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 5, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Signed-off-by: jingyang <3161362058@qq.com>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f52b174) 65.45% compared to head (8ba8a8a) 65.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4379   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 5, 2023
@zzjin zzjin added this to the v5.0 milestone Dec 5, 2023
@zzjin zzjin merged commit b6654c4 into labring:main Dec 5, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants