Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:launchpad issuer and certificates #4405

Merged
merged 2 commits into from Dec 13, 2023
Merged

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Dec 12, 2023

🤖[deprecated] Generated by Copilot at e6f40a3

Summary

🌐🚀🧹

This pull request adds a new feature to the frontend that allows users to import data from a cloud storage file to a database instance. It also improves the app deletion and update processes, refactors some functions for the app YAML files, and adds some translations and UI elements for the ConfigMap feature. The main files affected are delApp.ts, updateApp.ts, index.tsx, deployYaml2Json.ts, migrate.ts, createDump.ts, and common.json.

Oh we are the coders of the sea
We write and we patch and we deploy
We add and we edit and we translate
With ConfigMap and DumpForm and Ingress on the way

Walkthrough

  • Simplify and refactor the logic for creating and editing the app's YAML files (link, link, link, link, link, link)
  • Add and modify the code for deleting the Certificate and Issuer resources associated with the app that is being deleted (link, link, link)
  • Extract the names of the Issuer and Certificate resources from the jsonPatch object and use them as arguments for the patchNamespacedCustomObject function (link, link)
  • Replace the data.appName variable with the network.networkName variable as the argument for the secretName variable in the json2Ingress function (link)
  • Add the translation of the UI elements related to the ConfigMap, Age and Amount features to the common.json file for the English locale (link)
  • Add the translation of the UI element related to the ConfigMap Tip feature to the common.json file for the Chinese locale (link)
  • Render the translation of the ConfigMap Tip feature in the ModalHeader component (link)
  • Add a semicolon and a curly bracket to fix the syntax and formatting errors in the patch functions for the Service and Ingress resources (link, link)
  • Add console.log statements for debugging purposes and to verify the correctness and completeness of the data and variables related to the app's YAML files (link, link, link)
  • Modify the console.log statement in the DeleteAppByName function to add more information about the item being logged (link)
  • Add a new import statement for the DumpForm type in the migrate.ts file (link)
  • Add a new function called applyDumpCR to the migrate.ts file to send a POST request to the /api/migrate/createDump endpoint with the data for the dump import feature (link)
  • Add a new file called createDump.ts to the project to define the handler function for the /api/migrate/createDump endpoint and the json2DumpCR function (link)
  • Modify the import statements in the index.tsx file for the DumpImport component to add the applyDumpCR function and remove the json2DumpCR function (link, link)
  • Modify the handleDumpSubmit function in the index.tsx file for the DumpImport component to replace the json2DumpCR and applyYamlList functions with the applyDumpCR function (link)
  • Remove the json2DumpCR function from the json2Yaml.ts file (link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 12, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1148
✅ Successful 388
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 759
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 12, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b2fc94) 65.45% compared to head (e6f40a3) 65.45%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4405   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jingyang <3161362058@qq.com>
@c121914yu c121914yu merged commit 4c166d3 into labring:main Dec 13, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants