Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade and fix cloud build logic #4408

Merged
merged 3 commits into from Dec 13, 2023
Merged

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Dec 13, 2023

πŸ€–[deprecated] Generated by Copilot at 9d74d0e

Summary

πŸ—‘οΈπŸ†•πŸ”

This pull request updates the cloud installation process to use a new sealos-cloud image with an embedded license and a self-signed wildcard certificate for ingress. It also removes the unused free-license.yaml manifest and adjusts the install.sh and init.sh scripts accordingly.

To install cloud with sealos and k8s
We need a custom image and certs
So we patch ingress-nginx-controller
And use kustomize for tls-secret.yaml
And we drop the free-license.yaml that hurts

Walkthrough

  • Remove free-license.yaml manifest application from init.sh script (link), as sealos-cloud image has embedded license
  • Delete unused free-license.yaml manifest file (link)

Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 1148
βœ… Successful 388
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 759
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (c9527a7) 65.45% compared to head (9d74d0e) 65.45%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4408   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@lingdie lingdie merged commit a3efc3a into labring:main Dec 13, 2023
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants