-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix & style: tailwind css conflict and UI problem & clean some codes #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π€ Generated by lychee actionSummary
Full action output |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 β View full report in Codecov by Sentry. |
c121914yu
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€[deprecated] Generated by Copilot at ac3eb84
Summary
π οΈπ¨π±
The pull request adds a responsive sidebar to the kubepanel layout and fixes a style conflict between tailwind css and antd. It uses react hooks, antd components, and custom css to achieve the desired layout and appearance. It also deletes an unused file and adds some comments and configuration options.
Walkthrough
globals.css
, and removing the overflow: auto style from the sider (link) inlayout.tsx
kubernetes.ts
file as it is no longer needed (link)