Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix & style: tailwind css conflict and UI problem & clean some codes #4416

Merged
merged 26 commits into from
Dec 15, 2023
Merged

fix & style: tailwind css conflict and UI problem & clean some codes #4416

merged 26 commits into from
Dec 15, 2023

Conversation

Wishrem
Copy link
Contributor

@Wishrem Wishrem commented Dec 14, 2023

πŸ€–[deprecated] Generated by Copilot at ac3eb84

Summary

πŸ› οΈπŸŽ¨πŸ“±

The pull request adds a responsive sidebar to the kubepanel layout and fixes a style conflict between tailwind css and antd. It uses react hooks, antd components, and custom css to achieve the desired layout and appearance. It also deletes an unused file and adds some comments and configuration options.

Sing, O Muse, of the cunning code that resolved the clash
Of Tailwind and Antd, the mighty frameworks of the web,
How with skillful tweaks and comments they fixed the broken styles
And added a sidebar, like the gates of Troy, to the kubepanel.

Walkthrough

  • Fix a conflict between tailwind css and antd by adding an id attribute and a comment to the body element (link), disabling the preflight feature and adding a #app selector to the tailwind classes (link), importing the reset.css from antd and overriding some default tailwind properties (link) in globals.css, and removing the overflow: auto style from the sider (link) in layout.tsx
  • Delete the kubernetes.ts file as it is no longer needed (link)

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 1146
βœ… Successful 388
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 757
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@zzjin zzjin added this to the v5.0 milestone Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (94ac016) 65.45% compared to head (ac3eb84) 65.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4416   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit 37709ce into labring:main Dec 15, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants