Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style & feat: new UI components & automatically re-watch #4433

Merged
merged 41 commits into from Jan 10, 2024
Merged

style & feat: new UI components & automatically re-watch #4433

merged 41 commits into from Jan 10, 2024

Conversation

Wishrem
Copy link
Contributor

@Wishrem Wishrem commented Dec 18, 2023

Style:

  1. reposition components to fix next build
  2. new editor style
  3. clean some packages

Feat:

  1. automatically re-watch resources
  2. resource filter triggered by its name
  3. action button with delete popconfirm
  4. table pagination

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 18, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1145
✅ Successful 386
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 758
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e45e3b7) 65.45% compared to head (7e85053) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4433   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxy4543 bxy4543 added this to the v5.0 milestone Dec 19, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@Wishrem Wishrem changed the title style: new editor style and action button with new delete popconfirm style & feat: new UI components & automatically re-watch Jan 10, 2024
@c121914yu c121914yu merged commit 26e06ad into labring:main Jan 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants