New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate database svc and minio svc #4447
Conversation
🤖 Generated by lychee actionSummary
Errors per inputErrors in docs/blog/zh-Hans/2023/k8s-multi-tenancy.md
Errors in docs/blog/zh-Hans/2023/what-is-sealos.md
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4447 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
I don’t understand what this PR is used for. You need to add a more detailed explanation. |
} | ||
|
||
res, err := ps.Request(pr) | ||
listener, err := net.Listen("tcp", c.Server.ListenAddress) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use some http framework, like go-restful
The database and object-storage deploy the same monitoring service respectively, and the service code needs to be split, and the code optimization has not progressed. |
The database and object-storage deploy the same monitoring service respectively, and the service code needs to be split, and the code optimization has not progressed.