Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate database svc and minio svc #4447

Merged
merged 3 commits into from Jan 2, 2024
Merged

Conversation

nowinkeyy
Copy link
Contributor

@nowinkeyy nowinkeyy commented Dec 26, 2023

The database and object-storage deploy the same monitoring service respectively, and the service code needs to be split, and the code optimization has not progressed.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 26, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1147
✅ Successful 376
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 767
❓ Unknown 0
🚫 Errors 3

Errors per input

Errors in docs/blog/zh-Hans/2023/k8s-multi-tenancy.md

Errors in docs/blog/zh-Hans/2023/what-is-sealos.md

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d73becb) 65.45% compared to head (c2cf897) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4447   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fanux
Copy link
Member

fanux commented Dec 26, 2023

I don’t understand what this PR is used for. You need to add a more detailed explanation.

}

res, err := ps.Request(pr)
listener, err := net.Listen("tcp", c.Server.ListenAddress)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use some http framework, like go-restful

@nowinkeyy
Copy link
Contributor Author

I don’t understand what this PR is used for. You need to add a more detailed explanation.

The database and object-storage deploy the same monitoring service respectively, and the service code needs to be split, and the code optimization has not progressed.

@lingdie lingdie merged commit a35524d into labring:main Jan 2, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants