adapt install script for cockroachdb. #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
🤖 Generated by lychee actionSummary
Full action output |
lingdie
commented
Mar 14, 2024
Comment on lines
+642
to
+645
| # TODO use sealos run to install cockroachdb-operator | ||
| kubectl apply -f https://raw.githubusercontent.com/cockroachdb/cockroach-operator/v2.12.0/install/crds.yaml | ||
| kubectl apply -f https://raw.githubusercontent.com/cockroachdb/cockroach-operator/v2.12.0/install/operator.yaml | ||
|
|
There was a problem hiding this comment.
@wallyxjh please update this.
Signed-off-by: yy <lingdie.yy@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4593 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
lingdie
commented
Mar 14, 2024
| @@ -21,7 +21,7 @@ cloud_version="latest" | |||
| #single=y/n | |||
| image_registry=${image_registry:-"docker.io"} | |||
| image_repository=${image_repository:-"labring"} | |||
| kubernetes_version=${kubernetes_version:-"1.25.6"} | |||
| kubernetes_version=${kubernetes_version:-"1.27.11"} | |||
There was a problem hiding this comment.
@wallyxjh maybe we can use kubeblocks v0.7.2 or higher version? please check.
Comment on lines
+187
to
+188
| # sealos run tars/license.tar \ | ||
| # --env MONGO_URI="$mongodbUri" |
There was a problem hiding this comment.
@bxy4543 fix charge logic in license controller.
| @@ -139,7 +211,8 @@ function sealos_run_frontend { | |||
| --config-file etc/sealos/desktop-config.yaml | |||
|
|
|||
| # sealos authorize !!must run after sealos_run_controller frontend-desktop.tar and before sealos_run_frontend | |||
| sealos_authorize | |||
| # TODO fix sealos_authorize in controller/job/init | |||
There was a problem hiding this comment.
@bxy4543 fix sealos init admin user logic and add region data to CockroachDB in job/init
bxy4543
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.