PrawnBlaster binary programming #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note here: the docs build is failing because you are branched off master one commit behind the current HEAD (which fixes this issue). It's not a blocker, but if you make docs changes we'll want to rebase so they can get built correctly. |
|
Could you add something that falls back to the original behaviour for old firmware versions? You should be able to query the firmware version from the PrawnBlaster itself (over the serial connection). Anything less than v1.1.0 won't support the binary mode (which will be the earliest firmware version we'll be targeting with labscript-suite/PrawnBlaster#25) |
|
There is a better way to do the version number comparisons that I will implement soon. |
dihm
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labscript-devices side of PrawnBlaster PR #25.
Adds a fast binary mode for reprogramming the entire sequence, as well as heuristics for deciding when to use binary mode instead of incremental programming.
Verification testing has been performed, but performance testing is incomplete.