Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect AudioScheduledSoureNode::m_startTime and m_endTime #47

Closed
ddiakopoulos opened this issue Jan 3, 2016 · 2 comments
Closed

Protect AudioScheduledSoureNode::m_startTime and m_endTime #47

ddiakopoulos opened this issue Jan 3, 2016 · 2 comments
Assignees
@ddiakopoulos

Comments

@ddiakopoulos
Copy link
Member

https://chromium.googlesource.com/chromium/blink/+/41ec0c9d0880010388c417e7f521f2e9cd17f3be
@ddiakopoulos ddiakopoulos self-assigned this Jan 3, 2016
@meshula
Copy link
Member

meshula commented Oct 7, 2018

From the commit: Both AudioScheduledSourceNode::m_startTime and m_endTime can be
accessed by the main thread and the audio thread. The main thread
sets these when the node is scheduled to start or stop. The audio
thread needs to read these to determine if the node should actually
start or stop.

A mutex isn't the right for LabSound, but we should put some thought into how to treat these values such that there are not transient impossible states, like a node scheduled to end before it starts.

meshula added a commit to meshula/LabSound that referenced this issue Apr 13, 2019
@meshula
protect start/end times on scheduled node LabSound#47
ce3eeda
@meshula meshula mentioned this issue Apr 13, 2019
Merged
@meshula
Copy link
Member

meshula commented Apr 18, 2019

merged

@meshula meshula closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddiakopoulos ddiakopoulos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meshula @ddiakopoulos