Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bits (double) sample bit depth #53

Closed
sburkinan opened this issue Jan 31, 2017 · 4 comments
Closed

64 bits (double) sample bit depth #53

sburkinan opened this issue Jan 31, 2017 · 4 comments

Comments

@sburkinan
Copy link

Hello,
how difficult it would be to move the whole engine (including effects DSP, analysers with optimisations etc) to 64 bits double ?
I know this is not useful for most usages but I may have a use case (that I cannot disclose) that it would be necessary.

thank you

Steve

@ddiakopoulos
Copy link
Member

It's not such a huge codebase when you really dig in. I would trivially start just by changing every instance of float to double and see what happens... might take a few hours. Some 3rd party libraries would be more difficult... I think KissFFT/Ooura only works on floats? And libynyquist, our audio loader, will only return float vectors for audio files (not necessarily a problem if you are using an entirely procedural graph).

@sburkinan
Copy link
Author

Thank you Dimitri, I'll try as soon as I can.

@meshula
Copy link
Member

meshula commented Jan 31, 2017

One thing you might consider is upgrading the ChannelMerger and ChannelSplitter nodes to allow inputs and outputs of varying bit depth, or perhaps adding a BitDepthAdapter node. That would allow you to specialize only nodes that you need at greater bit depth without having to modify the entire codebase. You'd also have to modify the input and output objects to be bit aware.

@sburkinan
Copy link
Author

Thank you for your insights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants