Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalyserNode lacks setFftSize #75

Closed
raub opened this issue Mar 14, 2018 · 3 comments
Closed

AnalyserNode lacks setFftSize #75

raub opened this issue Mar 14, 2018 · 3 comments
Assignees

Comments

@raub
Copy link
Contributor

raub commented Mar 14, 2018

Hello.

Walking through the codes, I've just found that lab::AnalyserNode class lacks an ability to set fftSize value, it has only getter. Also lab::RealtimeAnalyser lacks the same thing.

However it exists in chromium's implementation of the above classes. And it doesn't seem to be too hacky. I think this method is needed, because the spec states that this property is settable.

As a temporary workaround I could resort to re-creating the lab::AnalyserNode instance in my JS (bindings) setter, whenever the fftSize value is changed from JS. But it would really be better if we avoided the hackery and put this feature into the core.

@meshula
Copy link
Member

meshula commented Mar 28, 2018

A little bit of factoring of RealtimeAnalyser could do the trick. m_analysisFrame and m_magnitudeBuffer need to be reinitialized, and it looks like everything will work fine.

@meshula meshula self-assigned this Mar 23, 2019
@meshula
Copy link
Member

meshula commented Mar 25, 2019

#113

@meshula
Copy link
Member

meshula commented Mar 27, 2019

Merged

@meshula meshula closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants