Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid decompression twice #38

Closed
dridk opened this issue Feb 20, 2017 · 4 comments
Closed

Avoid decompression twice #38

dridk opened this issue Feb 20, 2017 · 4 comments
Assignees
@Arkanosis @natir
Labels
enhancement help wanted
Milestone
0.3

Comments

@dridk
Copy link
Member

dridk commented Feb 20, 2017

Quote from @Arkanosis :
I'll rewrite this to avoid decompressing files twice (I'm pretty sure more time is spent currently decompressing compared to actually computing the statistics). Feel free to clean up, though, as I'm not sure when I'll do this.
@dridk dridk added this to the 0.3 milestone Feb 20, 2017
@dridk dridk mentioned this issue Feb 20, 2017
Closed
@natir natir self-assigned this Mar 4, 2017
@dridk
Copy link
Member Author

dridk commented Mar 14, 2017

For gzip, the total uncompress size is avaible from the 4 last bytes of the compressed file.
Nothing for bgzip... maybe something for LZMA

dridk added a commit that referenced this issue Mar 14, 2017
@dridk
Fix #38. Percent is now computed compressFile->pos() / compressFile->…
7605421 
…size()
@dridk dridk closed this as completed Mar 14, 2017
@Arkanosis
Copy link
Member

Awesome! \o/

@dridk
Copy link
Member Author

dridk commented Mar 15, 2017

yes ! it was really easy ! It's now incredible fast !

@ikit
Copy link
Member

ikit commented Mar 15, 2017

nice trick ! good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arkanosis Arkanosis

@natir natir

Labels
enhancement help wanted
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
4 participants
@Arkanosis @dridk @ikit @natir