Conditionally set url label for 404 responses

[therealak12]

The MR addresses #86. I've explained about it in the original issue. TLDR; It adds a new field to the MiddlewareConfig to control the URL label when the response status code is 404.

[aldas]

Please add test(s)

[aldas]

Test(s) are missing

[therealak12]

I've added two tests covering the new scenario. Thanks for reminding me.
@aldas

[therealak12]

Dear @aldas,
If you have a moment, would you be willing to kindly review the changes?

[aldas]

I think instead of SetPathFor404 *bool would DotNoUseURLFor404 bool would be better. Using pointers as configuration values is poor user experience.

[therealak12]

I think instead of SetPathFor404 *bool would DotNoUseURLFor404 bool would be better. Using pointers as configuration values is a poor user experience.

Thanks, dear @aldas. I renamed the field.

About using pointers, I used a pointer to be able to distinguish between the default false values and a nil value. What do you prefer as an alternative for this?

I can think of setting a default true value here to be backward compatible but it's not possible for the NewMiddlewareWithConfig function as it should be able to distinguish between false and nil in the passed configuration.

[aldas]

I do not think we need 3 cases. We only need config flag to invert current behavior.

[therealak12]

I do not think we need 3 cases. We only need config flag to invert current behavior.

Sorry, I was missing the change in semantics after renaming the variable. It's fixed now.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.08%. Comparing base (fdc9c9a) to head (48084db).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files           9        9           
  Lines         944      944           
=======================================
  Hits          605      605           
  Misses        300      300           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aldas]

LGTM